From 3d04995f97bcf99e6f4f2c9175f0dd574488ba84 Mon Sep 17 00:00:00 2001
From: "santasri.pachhal" <santasri.pachhal@sentientgeeks.com>
Date: Fri, 7 Aug 2026 16:38:38 +0530
Subject: [PATCH] perf(ticket): paginate and cache detection previews

---
 .../components/TicketAssignmentsCard.tsx      |  1 +
 .../components/TicketDetectionPreview.tsx     | 28 +++++++++++++------
 .../components/TicketDetectionPreviewCard.tsx |  1 +
 .../components/TicketUnassignedIssuesCard.tsx |  3 +-
 .../ticket/hooks/useTicketQueries.ts          | 10 ++++++-
 5 files changed, 32 insertions(+), 11 deletions(-)

diff --git a/src/app/(modules)/ticket/[ticketId]/components/TicketAssignmentsCard.tsx b/src/app/(modules)/ticket/[ticketId]/components/TicketAssignmentsCard.tsx
index 19f6cec..254850d 100644
--- a/src/app/(modules)/ticket/[ticketId]/components/TicketAssignmentsCard.tsx
+++ b/src/app/(modules)/ticket/[ticketId]/components/TicketAssignmentsCard.tsx
@@ -262,6 +262,7 @@ export function TicketAssignmentsCard({
               {videoId ? (
                 <div className={'mt-4 border-t pt-4'}>
                   <TicketDetectionPreview
+                    key={`${videoId}:${selectedAssignment.id}`}
                     ticketId={ticketId}
                     videoId={videoId}
                     assignmentId={selectedAssignment.id}
diff --git a/src/app/(modules)/ticket/[ticketId]/components/TicketDetectionPreview.tsx b/src/app/(modules)/ticket/[ticketId]/components/TicketDetectionPreview.tsx
index 8b6cc28..f5790e6 100644
--- a/src/app/(modules)/ticket/[ticketId]/components/TicketDetectionPreview.tsx
+++ b/src/app/(modules)/ticket/[ticketId]/components/TicketDetectionPreview.tsx
@@ -24,6 +24,8 @@ interface TicketDetectionPreviewProps {
   onDetectionCountChange?: (count: number | undefined) => void;
 }
 
+const DETECTION_PAGE_SIZE = 10;
+
 function DetectionMetadataBar({
   items,
 }: {
@@ -102,6 +104,8 @@ export function TicketDetectionPreview({
   const [currentIndex, setCurrentIndex] = useState(0);
   const [isDiscardDialogOpen, setIsDiscardDialogOpen] = useState(false);
   const isUnassignedPreview = assignmentStatus === 'unassigned';
+  const pageStart =
+    Math.floor(currentIndex / DETECTION_PAGE_SIZE) * DETECTION_PAGE_SIZE;
 
   useEffect(() => {
     setCurrentIndex(0);
@@ -109,23 +113,26 @@ export function TicketDetectionPreview({
 
   const queryParams = useMemo(
     () => ({
-      skip: currentIndex,
-      limit: 1,
+      skip: pageStart,
+      limit: DETECTION_PAGE_SIZE,
       assignment_id: isUnassignedPreview ? undefined : assignmentId,
       assignment_status: isUnassignedPreview
         ? ('unassigned' as const)
         : undefined,
       sort: 'timestamp_asc',
     }),
-    [assignmentId, currentIndex, isUnassignedPreview],
+    [assignmentId, isUnassignedPreview, pageStart],
   );
 
   const detectionsQuery = useTicketDetectionsQuery(
     videoId ?? undefined,
     queryParams,
+    { keepPreviousPage: true },
   );
   const detectionResult = detectionsQuery.data;
-  const activeDetection = detectionResult?.items[0];
+  const activeDetection = detectionsQuery.isPlaceholderData
+    ? undefined
+    : detectionResult?.items[currentIndex - pageStart];
   const confirmedDetectionCount = detectionResult?.total;
   const detectionCount = confirmedDetectionCount ?? 0;
   const activeVisual = getDefectVisual(
@@ -156,12 +163,15 @@ export function TicketDetectionPreview({
   }, [confirmedDetectionCount, currentIndex]);
 
   useEffect(() => {
-    onDetectionCountChange?.(confirmedDetectionCount);
-  }, [confirmedDetectionCount, onDetectionCountChange]);
+    onDetectionCountChange?.(detectionCount);
+  }, [detectionCount, onDetectionCountChange]);
 
   const isNavigationDisabled =
-    detectionCount === 0 || detectionsQuery.isLoading;
-  const isInitialLoading = detectionsQuery.isLoading;
+    detectionCount === 0 ||
+    detectionsQuery.isLoading ||
+    detectionsQuery.isPlaceholderData;
+  const isInitialLoading =
+    detectionsQuery.isLoading || detectionsQuery.isPlaceholderData;
   const isError = detectionsQuery.isError;
   const retry = () => void detectionsQuery.refetch();
 
@@ -221,7 +231,7 @@ export function TicketDetectionPreview({
         </div>
       </div>
 
-      {isInitialLoading && !activeDetection ? (
+      {isInitialLoading ? (
         <TicketDetectionPreviewSkeleton />
       ) : isError ? (
         <div className="rounded-lg border border-dashed border-destructive/40 bg-destructive/5 px-4 py-8 text-center">
diff --git a/src/app/(modules)/ticket/[ticketId]/components/TicketDetectionPreviewCard.tsx b/src/app/(modules)/ticket/[ticketId]/components/TicketDetectionPreviewCard.tsx
index d1c04c1..9edeb82 100644
--- a/src/app/(modules)/ticket/[ticketId]/components/TicketDetectionPreviewCard.tsx
+++ b/src/app/(modules)/ticket/[ticketId]/components/TicketDetectionPreviewCard.tsx
@@ -22,6 +22,7 @@ export function TicketDetectionPreviewCard({
       <CardContent className="p-5">
         <div className="min-w-0">
           <TicketDetectionPreview
+            key={`${videoId}:${assignmentId}`}
             ticketId={ticketId}
             videoId={videoId}
             assignmentId={assignmentId}
diff --git a/src/app/(modules)/ticket/[ticketId]/components/TicketUnassignedIssuesCard.tsx b/src/app/(modules)/ticket/[ticketId]/components/TicketUnassignedIssuesCard.tsx
index 2f85c81..cf1edc7 100644
--- a/src/app/(modules)/ticket/[ticketId]/components/TicketUnassignedIssuesCard.tsx
+++ b/src/app/(modules)/ticket/[ticketId]/components/TicketUnassignedIssuesCard.tsx
@@ -41,12 +41,13 @@ export function TicketUnassignedIssuesCard({
               results.
             </CardDescription>
           </div>
-           <Badge variant={'default'}>{detectionCount ?? 0} Unassigned</Badge>
+          <Badge variant={'default'}>{detectionCount ?? 0} Unassigned</Badge>
         </div>
       </CardHeader>
       <CardContent className={'p-5'}>
         <div className={'min-w-0'}>
           <TicketDetectionPreview
+            key={`${videoId}:unassigned`}
             ticketId={ticketId}
             videoId={videoId}
             assignmentStatus={'unassigned'}
diff --git a/src/app/(modules)/ticket/hooks/useTicketQueries.ts b/src/app/(modules)/ticket/hooks/useTicketQueries.ts
index 395443a..f888914 100644
--- a/src/app/(modules)/ticket/hooks/useTicketQueries.ts
+++ b/src/app/(modules)/ticket/hooks/useTicketQueries.ts
@@ -2,6 +2,7 @@
 
 import { useMemo } from 'react';
 import {
+  keepPreviousData,
   useInfiniteQuery,
   useMutation,
   useQuery,
@@ -28,6 +29,11 @@ import { extensionRequestKeys } from '../../extension-requests/queries/extension
 
 const TICKET_TABLE_REFRESH_MS = 5 * 60 * 1000;
 
+interface TicketDetectionsQueryOptions {
+  enabled?: boolean;
+  keepPreviousPage?: boolean;
+}
+
 interface UseTicketsQueryParams {
   skip: number;
   limit: number;
@@ -113,8 +119,9 @@ export function useTicketAssignmentsQuery(
 export function useTicketDetectionsQuery(
   videoId: string | undefined,
   params: VideoDetectionsParams,
-  enabled = true,
+  options: TicketDetectionsQueryOptions = {},
 ) {
+  const { enabled = true, keepPreviousPage = false } = options;
   const queryParams = useMemo(
     () => ({
       skip: params.skip ?? 0,
@@ -143,6 +150,7 @@ export function useTicketDetectionsQuery(
     queryFn: () =>
       videoService.getVideoDetections(videoId as string, queryParams),
     enabled: Boolean(enabled && videoId),
+    placeholderData: keepPreviousPage ? keepPreviousData : undefined,
     staleTime: Infinity,
   });
 }